Skip to content

[SPARK-25671] Build external/spark-ganglia-lgpl in Jenkins Test#22658

Closed
gatorsmile wants to merge 3 commits intoapache:masterfrom
gatorsmile:buildGanglia
Closed

[SPARK-25671] Build external/spark-ganglia-lgpl in Jenkins Test#22658
gatorsmile wants to merge 3 commits intoapache:masterfrom
gatorsmile:buildGanglia

Conversation

@gatorsmile
Copy link
Member

@gatorsmile gatorsmile commented Oct 6, 2018

What changes were proposed in this pull request?

Currently, we do not build external/spark-ganglia-lgpl in Jenkins tests when the code is changed.

How was this patch tested?

N/A

@SparkQA
Copy link

SparkQA commented Oct 6, 2018

Test build #97055 has finished for PR 22658 at commit 193751a.

  • This patch fails executing the dev/run-tests script.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gatorsmile gatorsmile changed the title [WIP] Build external/spark-ganglia-lgpl in Jenkins Test [SPARK-25671] Build external/spark-ganglia-lgpl in Jenkins Test Oct 6, 2018
@gatorsmile gatorsmile mentioned this pull request Oct 6, 2018
Closed
@gatorsmile
Copy link
Member Author

gatorsmile commented Oct 6, 2018 •
edited
Loading

In https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97062/console, it shows that spark-ganglia-lgpl is built and the compilation issues in GangliaSink.scala are captured.

[error] /home/jenkins/workspace/SparkPullRequestBuilder/external/spark-ganglia-lgpl/src/main/scala/org/apache/spark/metrics/sink/GangliaSink.scala:72: value xyz is not a member of object java.util.Locale
[error]     .map(u => TimeUnit.valueOf(u.toUpperCase(Locale.xyz)))
[error]                                                     ^
[error] one error found

@gatorsmile
Copy link
Member Author

gatorsmile commented Oct 6, 2018

cc @zsxwing @cloud-fan @HyukjinKwon

@SparkQA
Copy link

SparkQA commented Oct 6, 2018

Test build #97062 has finished for PR 22658 at commit 0c0a743.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gatorsmile
Copy link
Member Author

gatorsmile commented Oct 6, 2018

Also cc @yhuai @liancheng @srowen

@srowen
Copy link
Member

srowen commented Oct 6, 2018

Urf, yeah that was never covered I guess.
That statement should refer to Locale.ROOT. You'd be welcome to fix that here too I guess.

@gatorsmile
Copy link
Member Author

gatorsmile commented Oct 6, 2018

Locale.ROOT has been fixed as a hot-fix.

@SparkQA
Copy link

SparkQA commented Oct 6, 2018

Test build #97058 has finished for PR 22658 at commit e5d8042.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Oct 6, 2018

Test build #97064 has finished for PR 22658 at commit cd2264b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gatorsmile
Copy link
Member Author

gatorsmile commented Oct 6, 2018

Thanks! Merged to master/2.4

asfgit pushed a commit that referenced this pull request Oct 6, 2018
@gatorsmile
[SPARK-25671] Build external/spark-ganglia-lgpl in Jenkins Test
c8b9409 
## What changes were proposed in this pull request?
Currently, we do not build external/spark-ganglia-lgpl in Jenkins tests when the code is changed.

## How was this patch tested?
N/A

Closes #22658 from gatorsmile/buildGanglia.

Authored-by: gatorsmile <gatorsmile@gmail.com>
Signed-off-by: gatorsmile <gatorsmile@gmail.com>
(cherry picked from commit 8bb2429)
Signed-off-by: gatorsmile <gatorsmile@gmail.com>
@asfgit asfgit closed this in 8bb2429 Oct 6, 2018
@SparkQA
Copy link

SparkQA commented Oct 7, 2018

Test build #4360 has finished for PR 22658 at commit cd2264b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

HyukjinKwon
HyukjinKwon reviewed Oct 7, 2018
View reviewed changes
Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jackylee-ch pushed a commit to jackylee-ch/spark that referenced this pull request Feb 18, 2019
@gatorsmile
[SPARK-25671] Build external/spark-ganglia-lgpl in Jenkins Test
15949f9 
## What changes were proposed in this pull request?
Currently, we do not build external/spark-ganglia-lgpl in Jenkins tests when the code is changed.

## How was this patch tested?
N/A

Closes apache#22658 from gatorsmile/buildGanglia.

Authored-by: gatorsmile <gatorsmile@gmail.com>
Signed-off-by: gatorsmile <gatorsmile@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HyukjinKwon HyukjinKwon HyukjinKwon left review comments

@srowen srowen srowen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gatorsmile @SparkQA @srowen @HyukjinKwon